Fix for https://github.com/Brewtarget/brewtarget/issues/719 (Reset values of Specific Heat) #721
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the "short term" fix, but with some new code that will be part of the long-term fix sitting ready in the background.
Main changes are:
toSI()
totoCanonical()
andfromSI()
tofromCanonical()
. Most of our canonical forms are SI or some similar metric system, but, strictly speaking, we don't measure time duration, color, diastatic power etc in SI unitsLocalization::getLocale()
and changed calls toQLocale()
to callLocalization::getLocale()
instead. This makes it easy to override locale in the settings file for testing.BtFieldType
ofNonPhysicalQuantity::Dimensionless
for use in numerical fields where the user is not able to specify/choose the units in the input fieldBtLineEdit
child classesBtDimensionlessEdit
is the corollary toNonPhysicalQuantity::Dimensionless
. Others, such asBtViscosityEdit
, are mostly unused for now but will come into play when new fields are added as part of BeerJSON workMassOrVolumeAmt
, which will get used in the BeerJSON work (where more things can be measured by either mass or volume)Measurement::Amount
from a struct to a class so thatMassOrVolumeAmt
can inherit from itMeasurement
namespace for specific heat capacity - not currently used (as sticking with the hard-coding on Equipment for now) but will be in futureNamedParameterBundle
which will make it easier to have optional fields in future